Disable xray in the PR review environment #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll it not to load xray
andrewleith
changed the title
AWS_XRAY_SDK_ENABLED) to te…
🧪 Review environmenthttps://r6iwu6q4enmr3b6gsziisahu3m0qjdoq.lambda-url.ca-central-1.on.aws/ |
andrewleith
added a commit
that referenced
this pull request
Sep 19, 2024
andrewleith
added a commit
that referenced
this pull request
Sep 23, 2024
* fix(templates): update the preview logic so it correctly translates the template category value and passes it to the API when saving * fix(tests): update preview tests * feat(ui tests): add new scenarios to cover preview path * fix(tests): handle both when `FF_TEMPLATE_CATEGORY` is on and off * fix(create template): pass the template_category_id when previewing while creating a new template * task: try to disable xray in the PR review env * temporary: remove XRAY code to see if review env works * experiment: try using single quotes to init xray * task: disable xray in DEV/TEST * task: remove xray * task: re-enable xray * chore: formatting * task: disable xray again * task: undo things related to xray. fixed it in another PR (#1952) * test(template_categories): add scenario for creating + previewing a template before saving * chore: formatting * fix(tests): have the ui test remove the template it creates --------- Co-authored-by: Jumana B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Pr to disable xray in the PR review environments.
Test instructions | Instructions pour tester la modification