Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require description if the category is hidden #1910

Merged
merged 19 commits into from
Jul 31, 2024
Merged

Don't require description if the category is hidden #1910

merged 19 commits into from
Jul 31, 2024

Commits on Jul 29, 2024

  1. fix: dont require description if the category is hidden

    @andrewleith @jzbahrai
    andrewleith authored and jzbahrai committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1b8ce12 View commit details
    Browse the repository at this point in the history

  2. test: fix template category in the test data

    @andrewleith @jzbahrai
    andrewleith authored and jzbahrai committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    851cd90 View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @jzbahrai
    jzbahrai committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    37d199d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/hidden-category

    @andrewleith
    andrewleith authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0cb9e4f View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @andrewleith
    andrewleith committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4bdec1f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/hidden-category

    @andrewleith
    andrewleith authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    cc069c8 View commit details
    Browse the repository at this point in the history

  7. chore: formatting

    @andrewleith
    andrewleith committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1a9e293 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. test: rename test; add template-categories test suite to CI

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6f69a16 View commit details
    Browse the repository at this point in the history

  2. fix: default hidden categories to display as "other" on template list… 

    … and fitlers
    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7b274b8 View commit details
    Browse the repository at this point in the history

  3. fix(test): update test to look for "Other" category

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9738465 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/hidden-category

    @andrewleith
    andrewleith authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    87c4b40 View commit details
    Browse the repository at this point in the history

  5. fix: maintain category id of hidden categories

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    89cfa0a View commit details
    Browse the repository at this point in the history

  6. fix: sort filters alphabetically

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4bf3d33 View commit details
    Browse the repository at this point in the history

  7. test: ensure filters are sorted alphabetically

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d2158a9 View commit details
    Browse the repository at this point in the history

  8. chore: remove default value for FF_TEMPLATE_CATEGORY from test config… 

    … and rely on .env
    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    897bed9 View commit details
    Browse the repository at this point in the history

  9. chore: formatting

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    545461b View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into fix/hidden-category

    @andrewleith
    andrewleith authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0ba3875 View commit details
    Browse the repository at this point in the history

  11. chore: formatting

    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    365ca14 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'fix/hidden-category' of https://github.com/cds-snc/noti… 

    …fication-admin into fix/hidden-category
    @andrewleith
    andrewleith committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    499fe4a View commit details
    Browse the repository at this point in the history