Remove the FF_BOUNCE_RATE_V15 feature flag
#1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcmurtry
requested review from
andrewleith,
whabanks and
jzbahrai
and removed request for
andrewleith
🧪 Review environmenthttps://m7ldvmsz4cx62sbab5gaxb5kpy0eowur.lambda-url.ca-central-1.on.aws/ |
jzbahrai
approved these changes
Sep 12, 2023
andrewleith
reviewed
Sep 12, 2023
| @@ -138,7 +138,6 @@ class Config(object): | |||
|
|
|||
| # FEATURE FLAGS | |||
| FF_SALESFORCE_CONTACT = env.bool("FF_SALESFORCE_CONTACT", False) | |||
| FF_BOUNCE_RATE_V15 = env.bool("FF_BOUNCE_RATE_V15", False) | |||
| FF_SALESFORCE_CONTACT = env.bool("FF_SALESFORCE_CONTACT", False) | |||
There was a problem hiding this comment.
Duplicate line:
Suggested change
| FF_SALESFORCE_CONTACT = env.bool("FF_SALESFORCE_CONTACT", False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Remove the feature flag
FF_BOUNCE_RATE_V15and associated tests.Test instructions | Instructions pour tester la modification
Tests should pass in CI, the app should look the same as before.