Show message limits for trial services #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved some brittle tests
🧪 Review environmenthttps://bffivxzn7ffykoo5aiovxfii7q0bhdyb.lambda-url.ca-central-1.on.aws/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR updates the service settings page so that daily / yearly message limits for email and sms are displayed for trial services.
It also improves a couple of tests that relied on hard coded indexes to find specific rows in the service settings page. These tests should no longer fail and need attention whenever a new row is added to the service settings.
Test instructions | Instructions pour tester la modification
EmailsandText Messagessections