Fix/slack webhook calls not passing data (#2039)

* fix(workflows/slack webhook): encode JSON properly * fix: update workflows so that the variables are replaced properly
cds-snc · Jan 9, 2025 · 79ac85c · 79ac85c
1 parent 23a155b
commit 79ac85c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/cypress-staging.yaml b/.github/workflows/cypress-staging.yaml
@@ -38,5 +38,5 @@ jobs:
       - name: Notify Slack channel if this job failed
         if: ${{ failure() }}
         run: |
-          json='{"text":"<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/${GITHUB_RUN_ID}|see failure details> !"}'
+          json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}'
           curl -X POST -H 'Content-type: application/json' --data "$json"  ${{ secrets.SLACK_WEBHOOK }}
diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml
@@ -121,5 +121,5 @@ jobs:
     - name: Notify Slack channel if this job failed
       if: ${{ failure() }}
       run: |
-        json="{'text':'<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/${GITHUB_RUN_ID}|see failure details> !'}"
+        json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}'
         curl -X POST -H 'Content-type: application/json' --data "$json"  ${{ secrets.SLACK_WEBHOOK }}
diff --git a/.github/workflows/s3-backup.yml b/.github/workflows/s3-backup.yml
@@ -35,5 +35,5 @@ jobs:
     - name: Notify Slack channel if this job failed
       if: ${{ failure() }}
       run: |
-        json='{"text":"S3 backup failed in <https://github.com/${{ github.repository }}>!"}'
+        json='{"text":"S3 backup failed in <https://github.com/'${{ github.repository }}'>!"}'
         curl -X POST -H 'Content-type: application/json' --data "$json"  ${{ secrets.SLACK_NOTIFY_WEBHOOK }}
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -41,5 +41,5 @@ jobs:
     - name: Notify Slack channel if this job failed in default branch
       if: ${{ failure() && github.ref == 'refs/heads/main' }}
       run: |
-        json="{'text':'<!here> CI is failing in <https://github.com/cds-snc/notification-admin/|notification-admin> !'}"
+        json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/|notification-admin> !"}'
         curl -X POST -H 'Content-type: application/json' --data "$json"  ${{ secrets.SLACK_WEBHOOK }}
diff --git a/.github/workflows/test_prod_config.yaml b/.github/workflows/test_prod_config.yaml
@@ -44,5 +44,5 @@ jobs:
     - name: Notify Slack channel if this job failed in default branch
       if: ${{ failure() && github.ref == 'refs/heads/main' }}
       run: |
-        json="{'text':'<!here> CI is failing in <https://github.com/cds-snc/notification-admin/|notification-admin> !'}"
+        json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/|notification-admin> !"}'
         curl -X POST -H 'Content-type: application/json' --data "$json"  ${{ secrets.SLACK_WEBHOOK }}