add message origin checking for SMART Web Messaging #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barabo
changed the title
barabo
changed the title
|
@jmandel, @dennispatterson - PTAL |
jmandel
requested changes
Mar 15, 2020
Comment on lines
105
to
106
| // TODO: convert this to a stack so newer messages are on top. | ||
| this.setState({ messages: [...this.state.messages, message] }); |
There was a problem hiding this comment.
Do you want to swap the order of array elements here, so the splice comes in later? Otherwise, maybe remove the TODO or convert to a github issue.
Suggested change
| // TODO: convert this to a stack so newer messages are on top. | |
| this.setState({ messages: [...this.state.messages, message] }); | |
| this.setState({ messages: [message, ...this.state.messages] }); |
... but this probably needs additional tests, too. So, your call on how to incorporate.
There was a problem hiding this comment.
I've created a separate issue here: #129
Referencing the issue created to change the message ordering.
jmandel
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Looks good to me! @dennispatterson do you want to take a look too, or are you happy to merge?
dennispatterson
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a filter to enforce origin checking, causing the sandbox to ignore messages that don't match the expected origin. I've also updated the unit test to pass.