Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude predefined #67

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Exclude predefined #67

merged 17 commits into from
Dec 12, 2024

Conversation

cdot65
Copy link
Owner

@cdot65 cdot65 commented Dec 8, 2024

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

  • Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
  • Target your pull request to the main development branch in this repository.
  • Ensure your commit messages follow the project's preferred format.
  • Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

Refactor filtering logic to include the ability to exclude based on match criteria

What does this pull request accomplish?

  • Feature addition
  • Documentation update

Are there any breaking changes included?

  • Yes
  • No

Is there anything the reviewers should know?

Thank you for your contributions!

Simplified the initialization and method signatures in tag.py by removing unnecessary comments and streamlining the code structure. Enhanced the filter_tags functionality to support more flexible filtering options with exact matches and exclusion lists. These changes improve code readability and maintainability while expanding the filtering capabilities.
Simplified the initialization and method signatures in tag.py by removing unnecessary comments and streamlining the code structure. Enhanced the filter_tags functionality to support more flexible filtering options with exact matches and exclusion lists. These changes improve code readability and maintainability while expanding the filtering capabilities.
Simplified the initialization and method signatures in tag.py by removing unnecessary comments and streamlining the code structure. Enhanced the filter_tags functionality to support more flexible filtering options with exact matches and exclusion lists. These changes improve code readability and maintainability while expanding the filtering capabilities.
@cdot65 cdot65 self-assigned this Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
scm/config/objects/address.py 100.00% <100.00%> (ø)
scm/config/objects/address_group.py 100.00% <100.00%> (ø)
scm/config/objects/application.py 100.00% <100.00%> (ø)
scm/config/objects/application_filters.py 100.00% <100.00%> (ø)
scm/config/objects/application_group.py 100.00% <100.00%> (ø)
scm/config/objects/external_dynamic_lists.py 100.00% <100.00%> (ø)
scm/config/objects/service.py 100.00% <100.00%> (ø)
scm/config/objects/service_group.py 100.00% <100.00%> (ø)
scm/config/objects/tag.py 100.00% <100.00%> (ø)
scm/config/security/anti_spyware_profile.py 100.00% <100.00%> (ø)
... and 7 more

cdot65 added 14 commits December 8, 2024 13:22
Added support for excluding folders, snippets, and devices from the address filter results. Introduced an `exact_match` option to ensure the container matches precisely. This improves the flexibility and accuracy of filtering addresses based on specific criteria.
Enhanced the function to allow exclusion of folders, snippets, and devices, and added an exact_match parameter to return only container-exact matches. These changes increase the flexibility and precision of address group filtering, accommodating more specific querying needs. Furthermore, the application of these filters is modular, ensuring that none of the existing functionalities are disrupted.
Introduce optional `description`, `subcategory`, and `technology` fields to the application model to provide more detailed metadata. These enhancements are aimed at offering additional context and categorization, improving the information precision about each application.
Remove unnecessary comments for improved code clarity. Add new filtering options such as exact match and exclusion lists for folders, snippets, and devices. These changes enhance the flexibility and precision of the filtering process when fetching application data.
@cdot65 cdot65 merged commit cffb22c into main Dec 12, 2024
1 check passed
@cdot65 cdot65 deleted the exclude-predefined branch December 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant