Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-tag-actions #64

Merged
merged 6 commits into from
Dec 7, 2024
Merged

auto-tag-actions #64

merged 6 commits into from
Dec 7, 2024

Conversation

cdot65
Copy link
Owner

@cdot65 cdot65 commented Dec 7, 2024

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

  • Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
  • Target your pull request to the main development branch in this repository.
  • Ensure your commit messages follow the project's preferred format.
  • Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

Support for EDLs and Auto Tag Actions

What does this pull request accomplish?

  • Feature addition
  • Documentation update

Are there any breaking changes included?

  • Yes
  • No

Is there anything the reviewers should know?

Thank you for your contributions!

Introduce new files and classes for managing External Dynamic Lists (EDLs) within the SCM system, including create, update, delete, and fetch operations. This implementation provides support for filtering and handling EDL types such as IP, domain, URL, IMSI, and IMEI, along with corresponding data models and validation logic.
This commit introduces new factory classes for creating test data related to ExternalDynamicLists: create, update, and response models. These factories facilitate testing by providing a structured and easy way to generate valid and invalid instances of these models.
This commit introduces unit tests for ExternalDynamicLists models and their interactions with the API, covering scenarios for model creation, update, validation errors, and HTTP exceptions. The tests ensure proper validation and handling of various cases, including missing or multiple containers, error responses, and API request errors, thereby improving the codebase's robustness and reliability.
This commit introduces new documentation and models for managing External Dynamic Lists (EDLs) in the SDK, enhancing capabilities to handle IP, domain, URL, IMSI, and IMEI lists. Updates include new md files, index entries, and release notes detailing EDLs configuration, methods, and best practices.
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
scm/config/objects/__init__.py 100.00% <100.00%> (ø)
scm/config/objects/external_dynamic_lists.py 100.00% <100.00%> (ø)
scm/models/objects/__init__.py 100.00% <100.00%> (ø)
scm/models/objects/external_dynamic_lists.py 100.00% <100.00%> (ø)

@cdot65
Copy link
Owner Author

cdot65 commented Dec 7, 2024

Resolves #65 and #63

@cdot65 cdot65 merged commit 9255c36 into main Dec 7, 2024
2 checks passed
@cdot65 cdot65 deleted the auto-tag-actions branch December 7, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant