security-profiles #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved models into the 'objects' sub-directory and updated import paths across various files. Also reorganized the security-related files into the config/security directory for better module management.
The `validate_container_type` model validator was removed from the `AddressRequestModel`. This validator was duplicative as the necessary validation is already covered by another existing validator. Removing it helps simplify and streamline the code.
This method duplicate-checks a single condition that is already validated by another method. Removing it reduces the code complexity and minimizes the risk of conflicting validations.
Corrected file paths in application, address group, address, application group, and service models. Also, added an `__init__.py` file to the security module for proper module initialization.
Introduce comprehensive models for anti-spyware profiles, including actions, rules, threat exceptions, and API request/response structures. These models ensure accurate representation and validation of anti-spyware settings.
Introduced the `AntiSpywareProfile` class to manage Anti-Spyware Profiles within the SCM. Updated the relevant models and documentation to reflect the new functionality. Bumped version to 0.1.7 in `pyproject.toml`.
Implemented comprehensive validation and functionality tests for AntiSpywareProfile, including CRUD operations and model-specific checks. Extended AddressRequestModel tests to cover various validation cases, ensuring robustness and correctness of the models.
Reorganized the documentation to segregate configuration objects and security services for improved clarity. Deleted outdated models.md and created new directories for objects and security services each with dedicated overview files. Updated all relevant links and references accordingly.
Trimmed down class definitions in the Mermaid diagram for clarity and enhanced SDK documentation to include information about data model structures in Python dictionaries.
Bump the version in pyproject.toml to 0.1.8. Add release notes for version 0.1.8, including the addition of pytests to support Anti Spyware Profiles.
Updated the titles for Anti Spyware Security Profile in both configuration and model sections. This change enhances readability and provides a clearer understanding of the documentation structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for This Pull Request
🚨Please adhere to the guidelines for contributing to this repository.
Pull Request Description
Provide a detailed description of the changes your pull request introduces.
What does this pull request accomplish?
Are there any breaking changes included?
Is there anything the reviewers should know?
Thank you for your contributions!