Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106 firewall snapshot after upgrade not generated #107

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

cdot65
Copy link
Owner

@cdot65 cdot65 commented Mar 3, 2024

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

  • Ensure you are submitting your pull request to a branch dedicated to a specific topic/feature/bugfix. Avoid using the master branch for pull requests.
  • Target your pull request to the main development branch in this repository.
  • Ensure your commit messages follow the project's preferred format.
  • Check that your code additions do not fail any linting checks or unit tests.

Pull Request Description

Removes the else conditional in the post-upgrade snapshot workflow, which would have prevented snapshots from being taken on firewalls after they upgraded if a settings.yaml file was found in the current working directory.

What does this pull request accomplish?

  • Bug fix

Are there any breaking changes included?

  • Yes
  • No

Is there anything the reviewers should know?

Thank you for your contributions!

@cdot65 cdot65 added the bug Something isn't working label Mar 3, 2024
@cdot65 cdot65 self-assigned this Mar 3, 2024
@cdot65 cdot65 linked an issue Mar 3, 2024 that may be closed by this pull request
@cdot65 cdot65 merged commit 05386e9 into main Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall snapshot after upgrade not generated
1 participant