fix: deprecated properties not recorded

[rix0rrr]

In #646 we made a hotpatch to survive incorrectly specified deprecated properties, but made a mistake which removed all deprecation information from the DB.

Fix that.

[github-actions]

@aws-cdk/aws-service-spec: Model database diff detected

├[~] service aws-athena
│ └ resources
│    └[~] resource AWS::Athena::WorkGroup
│      └ properties
│         └ WorkGroupConfigurationUpdates: - WorkGroupConfigurationUpdates
│                                          + WorkGroupConfigurationUpdates (deprecated=WARN)
├[~] service aws-ec2
│ └ resources
│    └[~] resource AWS::EC2::EIPAssociation
│      └ properties
│         └ EIP: - string (immutable)
│                + string (deprecated=WARN, immutable)
├[~] service aws-finspace
│ └ resources
│    └[~] resource AWS::FinSpace::Environment
│      └ properties
│         └ DataBundles: - Array<string> (immutable)
│                        + Array<string> (deprecated=WARN, immutable)
├[~] service aws-gamelift
│ └ resources
│    └[~] resource AWS::GameLift::Fleet
│      └ properties
│         ├ LogPaths: - Array<string> (immutable)
│         │           + Array<string> (deprecated=WARN, immutable)
│         ├ ServerLaunchParameters: - string (immutable)
│         │                         + string (deprecated=WARN, immutable)
│         └ ServerLaunchPath: - string (immutable)
│                             + string (deprecated=WARN, immutable)
├[~] service aws-location
│ └ resources
│    ├[~] resource AWS::Location::GeofenceCollection
│    │ └ properties
│    │    ├ PricingPlan: - string
│    │    │              + string (deprecated=WARN)
│    │    └ PricingPlanDataSource: - string
│    │                             + string (deprecated=WARN)
│    └[~] resource AWS::Location::Tracker
│      └ properties
│         ├ PricingPlan: - string
│         │              + string (deprecated=WARN)
│         └ PricingPlanDataSource: - string
│                                  + string (deprecated=WARN)
├[~] service aws-rds
│ └ resources
│    └[~] resource AWS::RDS::DBInstance
│      └ properties
│         ├ TdeCredentialArn: - string
│         │                   + string (deprecated=WARN)
│         └ TdeCredentialPassword: - string
│                                  + string (deprecated=WARN)
├[~] service aws-sso
│ └ resources
│    └[~] resource AWS::SSO::InstanceAccessControlAttributeConfiguration
│      └ properties
│         └ InstanceAccessControlAttributeConfiguration: - InstanceAccessControlAttributeConfiguration
│                                                        + InstanceAccessControlAttributeConfiguration (deprecated=WARN)
├[~] service aws-synthetics
│ └ resources
│    └[~] resource AWS::Synthetics::Canary
│      └ properties
│         └ DeleteLambdaResourcesOnCanaryDeletion: - boolean
│                                                  + boolean (deprecated=WARN)
└[~] service aws-xray
  └ resources
     └[~] resource AWS::XRay::SamplingRule
       └ properties
          ├ RuleName: - string
          │           + string (deprecated=WARN)
          ├ SamplingRuleRecord: - SamplingRuleRecord
          │                     + SamplingRuleRecord (deprecated=WARN)
          └ SamplingRuleUpdate: - SamplingRuleUpdate
                                + SamplingRuleUpdate (deprecated=WARN)

[mrgrain]

So vain! 😂