New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sources): update stateful-resources #1106

Closed

aws-cdk-automation wants to merge 1 commit into main from update-source/stateful-resources

Contributor

aws-cdk-automation commented May 23, 2024 •

edited

Loading

⚠️ This Pull Request updates daily and will overwrite all manual changes pushed to the branch

Updates the stateful-resources source from upstream. See details in workflow run.

Automatically created by projen via the "update-source-stateful-resources" workflow

github-actions bot commented May 23, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation added the auto-approve label

aws-cdk-automation force-pushed the update-source/stateful-resources branch from c6f7400 to c06fbd4 Compare

May 23, 2024 03:15

github-actions bot approved these changes

View reviewed changes

aws-cdk-automation enabled auto-merge

May 23, 2024 03:15

aws-cdk-automation force-pushed the update-source/stateful-resources branch from c06fbd4 to 3012087 Compare

May 24, 2024 03:15

github-actions bot commented May 24, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

1 similar comment

github-actions bot commented May 27, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 3012087 to 8cd4e3e Compare

May 27, 2024 03:15

github-actions bot commented May 28, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch 2 times, most recently from e69dedf to 2f0001f Compare

May 29, 2024 03:15

github-actions bot commented May 29, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 2f0001f to d1c93b2 Compare

May 30, 2024 03:15

github-actions bot commented May 30, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from d1c93b2 to 6c6f257 Compare

May 31, 2024 03:15

github-actions bot commented May 31, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

1 similar comment

github-actions bot commented Jun 3, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch 2 times, most recently from d988d23 to ce3be2c Compare

June 4, 2024 03:15

github-actions bot commented Jun 4, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from ce3be2c to 8cb811b Compare

June 5, 2024 03:15

github-actions bot commented Jun 5, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

1 similar comment

github-actions bot commented Jun 6, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 8cb811b to 086706d Compare

June 7, 2024 03:15

github-actions bot commented Jun 7, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 086706d to c36aa07 Compare

June 10, 2024 03:15

github-actions bot commented Jun 10, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from c36aa07 to d8fd2f4 Compare

June 11, 2024 03:15

github-actions bot commented Jun 11, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

github-actions bot commented Sep 13, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 15bb8f0 to 542ad13 Compare

September 16, 2024 03:17

github-actions bot commented Sep 16, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 542ad13 to 3bb180b Compare

September 17, 2024 03:16

github-actions bot commented Sep 17, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 3bb180b to 2de9ae5 Compare

September 18, 2024 03:16

github-actions bot commented Sep 18, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 2de9ae5 to 6079a22 Compare

September 19, 2024 03:16

github-actions bot commented Sep 19, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 6079a22 to 6144f8a Compare

September 20, 2024 03:16

github-actions bot commented Sep 20, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 6144f8a to 75e1042 Compare

September 23, 2024 03:17

github-actions bot commented Sep 23, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 75e1042 to 041e3a5 Compare

September 24, 2024 03:16

github-actions bot commented Sep 24, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 041e3a5 to 009a833 Compare

September 25, 2024 03:17

github-actions bot commented Sep 25, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 009a833 to 07e6e39 Compare

September 26, 2024 03:16

github-actions bot commented Sep 26, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

aws-cdk-automation force-pushed the update-source/stateful-resources branch from 07e6e39 to eb21e58 Compare

September 27, 2024 03:17

github-actions bot commented Sep 27, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"


          feat(sources): update stateful-resources

b524028

> ⚠️ This Pull Request updates daily and will overwrite **all** manual changes pushed to the branch

Updates the stateful-resources source from upstream. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/awscdk-service-spec/actions/runs/11098753240

------

*Automatically created by projen via the "update-source-stateful-resources" workflow*

Signed-off-by: github-actions <[email protected]>

aws-cdk-automation force-pushed the update-source/stateful-resources branch from eb21e58 to b524028 Compare

September 30, 2024 03:18

github-actions bot commented Sep 30, 2024

To work on this Pull Request, please create a new branch and PR. This prevents your work from being deleted by the automation.

Run the following commands inside the repo:

gh co 1106
git switch -c fix-pr-1106 && git push -u origin HEAD
gh pr create -t "fix: PR #1106" --body "Fixes https://github.com/cdklabs/awscdk-service-spec/pull/1106"

iliapolo mentioned this pull request

chore: fail downloading sources on http status code != 200 #1331

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          chore: fail downloading sources on http status code != 200 (#1331)

4a9130b

Our [feat(sources): update
stateful-resources](#1106)
PR is currently failing to build:

```console
👾 build » compile » build:db | ts-node build/build-db.ts
FAIL


SyntaxError: Unexpected non-whitespace character after JSON at position 3
```

This happens because the `StatefulResources.json` file got updated with
an invalid value. Our workflow updates this with the contents of
`StatefulResources.json` coming from
[cfn-lint](https://github.com/aws-cloudformation/cfn-lint). However, In
aws-cloudformation/cfn-lint#3257, this file was
[removed](https://raw.githubusercontent.com/aws-cloudformation/cfn-lint/main/src/cfnlint/data/AdditionalSpecs/StatefulResources.json)
(it is now inlined inside the python file that was using it). This
results in the file being updated with the string `404: Not Found` -
which is not a valid JSON.

In this scenario, we shouldn't have even created the PR, but rather fail
during the workflow execution. We didn't because our workflow ignores
http status codes when downloading a source, this PR fixes that.

### Notes

- This replaces build failure with workflow execution failure, but we
still need to figure out how to handle the file removal.

Contributor

iliapolo commented Sep 30, 2024

Closing this because this should have never been created. See #1331.

iliapolo closed this

auto-merge was automatically disabled

September 30, 2024 09:04

Pull request was closed

iliapolo deleted the update-source/stateful-resources branch

September 30, 2024 09:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels