Skip to content

Commit

Permalink
chore: remove redundant step from integration test setup (#528)
Browse files Browse the repository at this point in the history
This step is not needed anymore since `aws/aws-cdk` is now officially
using the new service-spec.
Previously we needed to overwrite the import statement to use the new
code.
  • Loading branch information
mrgrain authored Sep 12, 2023
1 parent bb179ff commit 556e845
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/test-aws-cdk-integration.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions projenrc/aws-cdk-integration-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export class AwsCdkIntegrationTest extends pj.Component {
...checkoutRepository(awsCdkRepo, awsCdkPath),
...linkPackage(options.serviceSpec, awsCdkPath),
...linkPackage(options.serviceSpecTypes, awsCdkPath),
...useSpec2Cdk(awsCdkPath),
...buildAwsCdkLib(awsCdkRepo, awsCdkPath),
...runJsiiDiff(candidateSpec, diffIgnoreFile),
],
Expand Down Expand Up @@ -105,16 +104,6 @@ function linkPackage(project: pj.Project, targetPath: string): pj.github.workflo
];
}

function useSpec2Cdk(path: string): pj.github.workflows.Step[] {
return [
{
name: `Use spec2cdk`,
workingDirectory: path,
run: `echo "export * from '@aws-cdk/spec2cdk/lib/cfn2ts';" > packages/aws-cdk-lib/scripts/codegen.ts`,
},
];
}

function buildAwsCdkLib(repository: string, path: string): pj.github.workflows.Step[] {
return [
{
Expand Down

0 comments on commit 556e845

Please sign in to comment.