Skip to content

Commit

Permalink
chore(deps): upgrade dependencies (#805)
Browse files Browse the repository at this point in the history
Fixes failing upgrade workflows.

Recent changes in upstream projen caused our release hacks to fail.
Refactored the workspace release component to be less hacky.
  • Loading branch information
mrgrain authored Jan 8, 2024
1 parent 65219f2 commit 367cc93
Show file tree
Hide file tree
Showing 34 changed files with 165 additions and 175 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion .github/workflows/upgrade.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-service-spec/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-service-spec/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/@aws-cdk/aws-service-spec/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/@aws-cdk/aws-service-spec/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-service-spec/tsconfig.dev.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-importers/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/service-spec-importers/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/@aws-cdk/service-spec-importers/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/@aws-cdk/service-spec-importers/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-importers/tsconfig.dev.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-types/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/service-spec-types/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/@aws-cdk/service-spec-types/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/@aws-cdk/service-spec-types/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-types/tsconfig.dev.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@cdklabs/tskb/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@cdklabs/tskb/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/@cdklabs/tskb/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/@cdklabs/tskb/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@cdklabs/tskb/tsconfig.dev.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@cdklabs/typewriter/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@cdklabs/typewriter/.npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/@cdklabs/typewriter/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/@cdklabs/typewriter/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/@cdklabs/typewriter/tsconfig.dev.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions projenrc/monorepo-release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export class MonorepoRelease extends Component {
private readonly releaseTrigger: release.ReleaseTrigger;
private readonly packagesToRelease = new Array<{
readonly workspaceDirectory: string;
readonly release: release.Release;
readonly release: {
readonly project: TypeScriptWorkspace;
readonly publisher: release.Publisher;
};
}>();

private workflow?: github.TaskWorkflow;
Expand All @@ -79,12 +82,15 @@ export class MonorepoRelease extends Component {
publishToNpm: this.options.publishToNpm,
...options,
});
if (!options.private && workspaceRelease.release) {
if (!options.private && workspaceRelease.publisher) {
this.obtainReleaseTask();

this.packagesToRelease.push({
workspaceDirectory: project.workspaceDirectory,
release: workspaceRelease.release,
release: {
project: workspaceRelease.project,
publisher: workspaceRelease.publisher,
},
});
}
}
Expand All @@ -110,7 +116,7 @@ export class MonorepoRelease extends Component {
name: `${release.project.name}: Backup artifact permissions`,
if: noNewCommits,
continueOnError: true,
run: `cd ${release.artifactsDirectory} && getfacl -R . > ${PERMISSION_BACKUP_FILE}`,
run: `cd ${release.project.artifactsDirectory} && getfacl -R . > ${PERMISSION_BACKUP_FILE}`,
workingDirectory: workspaceDirectory,
},
{
Expand All @@ -120,7 +126,7 @@ export class MonorepoRelease extends Component {
with: {
// Every artifact must have a unique name
name: buildArtifactName(release.project),
path: path.join(workspaceDirectory, release.artifactsDirectory),
path: path.join(workspaceDirectory, release.project.artifactsDirectory),
},
},
);
Expand Down Expand Up @@ -290,7 +296,7 @@ export class MonorepoRelease extends Component {
checkoutWith: {
// we must use 'fetch-depth=0' in order to fetch all tags
// otherwise tags are not checked out
'fetch-depth': 0,
fetchDepth: 0,
},
preBuildSteps,
task: this.releaseTask!,
Expand Down
Loading

0 comments on commit 367cc93

Please sign in to comment.