Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no-longer-needed JSaddle workarounds #127

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Remove no-longer-needed JSaddle workarounds #127

merged 1 commit into from
Oct 1, 2023

Conversation

georgefst
Copy link
Collaborator

Undoes #125.

@georgefst
Remove no-longer-needed JSaddle workarounds
e18878d 
We can now build on GHCs 9.4 and 9.6 without vendoring.
cdepillabout
cdepillabout approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@georgefst georgefst merged commit cb88f2e into master Oct 1, 2023
10 checks passed
@georgefst georgefst deleted the jsaddle-hackage branch October 1, 2023 00:18
@georgefst
Copy link
Collaborator Author

I actually needed this to unblock building with GHC 9.6 (which is now possible with cabal build all -w ghc-9.6.3 --allow-newer=servant-lucid:servant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgefst @cdepillabout