Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the fault_tolerant flag in the qsample protocol. #359

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Jan 13, 2025

Description

This PR fixes a minor problem in the simulation of deterministic state preparation circuits. qsample protocols need to be flagged whether they are fault-tolerant or not at construction to ensure that bounds are correctly computed. This PR sets this flag.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.7%. Comparing base (3cef58e) to head (3981e02).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #359   +/-   ##
=====================================
  Coverage   87.7%   87.7%           
=====================================
  Files         58      58           
  Lines       5126    5126           
  Branches     372     372           
=====================================
  Hits        4498    4498           
  Misses       628     628           
Flag Coverage Δ *Carryforward flag
cpp 83.7% <ø> (ø) Carriedforward from 3cef58e
python 89.6% <100.0%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/circuit_synthesis/simulation_det.py 92.2% <100.0%> (ø)

@pehamTom pehamTom merged commit 2ad64ea into main Jan 14, 2025
24 checks passed
@pehamTom pehamTom deleted the fix_plots_in_det_sp branch January 14, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant