Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend functionality for working with codes. #288

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Extend functionality for working with codes. #288

merged 20 commits into from
Nov 20, 2024

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Sep 25, 2024 •
edited
Loading

Description

This PR extends QECCs capabilities for working with stabilizer codes. The following features are planned:

  • Refactor Pauli operator and symplectic vector functionality
  • Add more codes and unify their creation
    • Quantum Hamming Codes
    • Bring Code
    • Many-Hypercube Code
  • Add support for code concatenation

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@pehamTom pehamTom added enhancement Enhancement to existing feature feature New feature or request code quality Code quality improvements labels Sep 25, 2024
@pehamTom pehamTom self-assigned this Sep 25, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 25, 2024
View reviewed changes
src/mqt/qecc/codes/pauli.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/stabilizer_code.py Fixed Show fixed Hide fixed
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.23308% with 27 lines in your changes missing coverage. Please review.

Project coverage is 88.4%. Comparing base (ef25257) to head (5cc9bf5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qecc/codes/concatenation.py 84.5% 13 Missing ⚠️
src/mqt/qecc/codes/pauli.py 93.6% 8 Missing ⚠️
src/mqt/qecc/codes/stabilizer_code.py 94.9% 3 Missing ⚠️
src/mqt/qecc/codes/symplectic.py 96.2% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #288     +/-   ##
=======================================
+ Coverage   88.1%   88.4%   +0.3%     
=======================================
  Files         53      57      +4     
  Lines       4834    5113    +279     
  Branches     372     372             
=======================================
+ Hits        4259    4521    +262     
- Misses       575     592     +17
Flag Coverage Δ *Carryforward flag
cpp 83.8% <ø> (ø) Carriedforward from 46a7a44
python 90.6% <93.2%> (+0.2%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qecc/codes/__init__.py 100.0% <100.0%> (ø)
src/mqt/qecc/codes/constructions.py 100.0% <100.0%> (ø)
src/mqt/qecc/codes/css_code.py 92.7% <100.0%> (+5.2%) ⬆️
src/mqt/qecc/codes/stabilizer_code.py 94.8% <94.9%> (-0.9%) ⬇️
src/mqt/qecc/codes/symplectic.py 96.2% <96.2%> (ø)
src/mqt/qecc/codes/pauli.py 93.6% <93.6%> (ø)
src/mqt/qecc/codes/concatenation.py 84.5% <84.5%> (ø)
---- 🚨 Try these New Features:

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 26, 2024
View reviewed changes
src/mqt/qecc/codes/concatenation.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/concatenation.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/concatenation.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/concatenation.py Fixed Show fixed Hide fixed
src/mqt/qecc/codes/concatenation.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2024
View reviewed changes
test/python/test_code.py Fixed Show fixed Hide fixed
@pehamTom
Improve coverage.
642b037 
Added tests for symplectic vectors and matrices.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
test/python/test_code.py Fixed Show fixed Hide fixed
@pehamTom pehamTom requested a review from lucasberent October 23, 2024 07:48
@pehamTom pehamTom marked this pull request as ready for review November 20, 2024 16:25
@pehamTom pehamTom merged commit 0880e37 into main Nov 20, 2024
21 of 22 checks passed
@pehamTom pehamTom deleted the concatenated-codes branch November 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasberent lucasberent Awaiting requested review from lucasberent

Assignees

@pehamTom pehamTom

Labels
code quality Code quality improvements enhancement Enhancement to existing feature feature New feature or request
Projects
MQT Error Correction
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pehamTom