-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Enforce runtime evaluation of dynamic formatting strings to fix consteval
contexts
#585
base: main
Are you sure you want to change the base?
Conversation
…nsteval` contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 98.09% 98.10%
=======================================
Files 232 232
Lines 35300 35300
Branches 1700 1700
=======================================
+ Hits 34628 34630 +2
+ Misses 672 670 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
"?"); | ||
const auto* dir = "?"; | ||
|
||
switch (p.dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]
switch (p.dir)
^
Description
This PR enforces the use of
fmt::runtime
in scenarios where dynamic formatting strings are used with the{fmt}
library in order to fix compilation errors when these functions are used inconsteval
contexts.Checklist: