Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- added inAppBrowserOptions in calling openfb api; #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IvanProdaiko94
Copy link

The problem this commit will solve is an ability to use inAppBrowser behaviour while using "openFB".

In my resent project (it was about cutting of videos) I have faced the problem, that after using libruary all videos that had inline attribute stops to play inline on IOS. As far as I understood, parameters that you pass to inAppBrowser after it closing will be applied to your main window. Unfortunately I had no ability to control this behaviour while using "openFB", but this these small chenges I can do it.

@nosovk
Copy link

nosovk commented Feb 12, 2017

Isn't better solution to add separate setOptions/getOptions methods into InAppBrowser instead of patching library that depends on it? That way we can save and restore settings of IAB. But this is also a solution, cause it will not break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants