Skip to content

Commit

Permalink
Fixed a bug that prevented storing passwords for new cctray pipelines.
Browse files Browse the repository at this point in the history
This should fix / help with #13.
  • Loading branch information
erikdoe committed Aug 15, 2024
1 parent 81df695 commit 14812a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CCMenu/Resources/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<key>CFBundlePackageType</key>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>25.0</string>
<string>25.1</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
Expand All @@ -34,7 +34,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>2250.1</string>
<string>2251.1</string>
<key>LSApplicationCategoryType</key>
<string>public.app-category.developer-tools</string>
<key>LSMinimumSystemVersion</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ class CCTrayPipelineBuilder: ObservableObject {
components.user = credential.user
if !credential.password.isEmpty {
do {
try Keychain.standard.setPassword(credential.password, forURL: url.absoluteString)
let newUrl = components.url?.absoluteURL ?? url
try Keychain.standard.setPassword(credential.password, forURL: newUrl.absoluteString)
} catch {
// TODO: Figure out what to do here – so many errors...
}
Expand Down

0 comments on commit 14812a5

Please sign in to comment.