Use modern APT keyrings on Debian family #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This prevent this deprecation warning on Debian 12 (for which AIO packages are still not available so not part of the CI test matrix for now, but this is another problem): |
smortex
force-pushed
the
modern-apt-keyring
branch
3 times, most recently
from
7b96981
to
8efdaaa
Compare
|
Relevant discussion: Embedding the key in the module is a bit "meh", but in case of compromission of the repo, fetching a rogue key and installing rogue packages is not as straightforward… |
smortex
force-pushed
the
modern-apt-keyring
branch
2 times, most recently
from
8917cce
to
44ca7ac
Compare
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
force-pushed
the
modern-apt-keyring
branch
from
44ca7ac
to
319c89e
Compare
|
I reworked the PR to include a copy of the key in the module. Feels better IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key
in
/etc/apt/keyringsand add asigned-byoption to thesources.list.dentry.