UniFFI for multi language bindings #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaesaecracker
force-pushed
the
uniffi2
branch
5 times, most recently
from
132dce7
to
a1ce989
Compare
kaesaecracker
commented
Nov 12, 2024
| ${BINDGEN} generate $COMMON_ARGS --language swift --out-dir "$LIBRARIES_PATH/swift" | ||
| ${BINDGEN} generate $COMMON_ARGS --language ruby --out-dir "$LIBRARIES_PATH/ruby" | ||
| ${BINDGEN_CS} $COMMON_ARGS --out-dir "$LIBRARIES_PATH/csharp/ServicePoint" | ||
| ${BINDGEN_GO} $COMMON_ARGS --out-dir "$LIBRARIES_PATH/go/" |
There was a problem hiding this comment.
one crate per supported language, dependency in Cargo.toml, build.rs that generates library
that way the directories are less nested and the bindings get built by cargo build --all
kaesaecracker
commented
Nov 12, 2024
| BINDGEN="cargo run --features=uniffi/cli --bin uniffi-bindgen -- " | ||
| BINDGEN_CS="cargo run --features=cs --bin uniffi-bindgen-cs -- " | ||
| BINDGEN_GO="cargo run --features=go --bin uniffi-bindgen-go -- " | ||
| COMMON_ARGS="--library $SERVICEPOINT_SO" |
There was a problem hiding this comment.
remove checked-in code, at least for languages that are not tested yet and do not have a project file to reference
kaesaecracker
commented
Nov 12, 2024
| /// by explicitly calling `sp_connection_free`. | ||
| /// </summary> | ||
| [DllImport(__DllName, EntryPoint = "sp_connection_fake", CallingConvention = CallingConvention.Cdecl, ExactSpelling = true)] | ||
| public static extern Connection* sp_connection_fake(); |
There was a problem hiding this comment.
remove old lib if all functionality is provided in the new one
kaesaecracker
commented
Nov 12, 2024
crates/servicepoint/src/char_grid.rs
Outdated
| /// A grid containing UTF-8 characters. | ||
| pub type CharGrid = PrimitiveGrid<char>; | ||
|
|
||
| impl CharGrid { |
There was a problem hiding this comment.
move base crate changes into PR that can be merged before this one
kaesaecracker
force-pushed
the
uniffi2
branch
from
6e58e74
to
15c0eb5
Compare
|
Constants are missing from the bindings |
kaesaecracker
force-pushed
the
uniffi2
branch
from
15c0eb5
to
0aa6514
Compare
cs not working
kaesaecracker
force-pushed
the
uniffi2
branch
from
0aa6514
to
83e31e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.