Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In spec only S3 old key dropped before verify new key operation #82

Merged

Conversation

OuyangHang33
Copy link
Collaborator

@OuyangHang33 OuyangHang33 commented Apr 25, 2024

Ref: #7

SpdmKeyUpdateOperation::SpdmUpdateAllKeys => {
let _ = session.create_data_secret_update(spdm_version_sel, true, true);
let _ = session.activate_data_secret_update(spdm_version_sel, true, true, true);
}
SpdmKeyUpdateOperation::SpdmVerifyNewKey => {
let _ = session.activate_data_secret_update(spdm_version_sel, true, false, true);

image

@OuyangHang33 OuyangHang33 force-pushed the fix_wrong_drop_method_in_verify_key branch from 3e153ac to 6b0f626 Compare April 25, 2024 02:03
@jyao1 jyao1 merged commit 90dc8da into ccc-spdm-tools:main Apr 26, 2024
52 checks passed
@OuyangHang33 OuyangHang33 deleted the fix_wrong_drop_method_in_verify_key branch April 28, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants