test: spdm-requester-emu: Remove the hello packet #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
approved these changes
Jul 26, 2024
alistair23
force-pushed
the
alistair/hello-removal
branch
from
fa35206 to
0f9b183
Compare
|
Rebased, that might fix the CI failures |
|
please fix CI failure |
The hello message isn't used on QEMU [1] or SPDM-Utils [2], so let's remove it here as we don't need it and it breaks compability with other emulators. 1: https://github.com/qemu/qemu/blob/029e13a8a56a2931e7c24c0db52ae7256b932cb0/docs/specs/spdm.rst#L42 2: https://github.com/westerndigitalcorporation/spdm-utils Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/hello-removal
branch
from
0f9b183 to
635ed58
Compare
alistair23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hello message isn't used on QEMU [1] or SPDM-Utils [2], so let's remove it here as we don't need it and it breaks compability with other emulators.
1: https://github.com/qemu/qemu/blob/029e13a8a56a2931e7c24c0db52ae7256b932cb0/docs/specs/spdm.rst#L42
2: https://github.com/westerndigitalcorporation/spdm-utils