Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sgx properties #229

Merged
merged 26 commits into from
Dec 4, 2023
Merged

Sgx properties #229

merged 26 commits into from
Dec 4, 2023

Conversation

jlmucb
Copy link
Collaborator

@jlmucb jlmucb commented Nov 15, 2023

This adds platform property verification to Gramine enclaves.

This puts SGX on parity with SEV.

@jlmucb jlmucb requested a review from yelvmw November 19, 2023 03:54
@jlmucb jlmucb marked this pull request as ready for review November 19, 2023 03:55
@yelvmw
Copy link
Contributor

yelvmw commented Nov 25, 2023

It looks you decided to logically separate Gramine with and without platform evidence. This might be a simplification for now. But the result is that we either have to have platform properties in the policy or not. I don't think this is the right way to go. The choice should be handled given whether platform properties are present in the policies and this alone.

The current code will fail if I don't supply any platform properties. Additionally, I think we might have a bug in constructing the platform properties. If we remove a property from the policy (e.g., remove qeSVN, which should be valid), the verification should just treat it as if the specific property does not matter. However, the current code fails the verification. I'll dig deeper to see what went wrong.

jlmucb and others added 4 commits November 28, 2023 12:30
Ignored missing properties and assume any values are accepted by the
user. Also added new slide deck to documentations.
@yelvmw yelvmw merged commit 8123a98 into main Dec 4, 2023
1 check passed
@yelvmw yelvmw deleted the sgx-properties branch December 4, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants