Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toast Notification on warnings or errors. #12

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kriserickson
Copy link

I found that some errors and warnings sent to the logger where getting ignored so I added a visible notification of errors and warnings sent from the server.

@syabro
Copy link

syabro commented Apr 23, 2013

Toast notification looks like good idea, but it's very rude to upgrade whole script to your own code style

@ccampbell
Copy link
Owner

@syabro it looks like some of the code was actually from 11 months ago. I think I updated some of the code formatting since then 😄

I do agree those should be updated. I haven't had time to play around with this PR yet, but hopefully will get to soon.

@kriserickson
Copy link
Author

Apologies if any of the code formatting changed, I tried to change as little as possible however I use WebStorm which auto-formats code on paste's and such and @ccampbell is correct the changes were actually made from the codebase from months ago and I obviously had some merge issues when I merged to the latest code (which is much cleaner BTW).

@mindplay-dk
Copy link

To others looking for a solution, this extension should do it for every console error:

https://chrome.google.com/webstore/detail/javascript-errors-notifie/jafmfknfnkoekkdocjiaipcnmkklaajd?hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants