Cleanup CSSOM specific test cases. #7

cburgmer · Jun 4, 2017 · 22bc341 · 22bc341
1 parent c9dbadd
commit 22bc341
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 99 deletions.
diff --git a/test/specs/InlineCssLinksIntegrationSpec.js b/test/specs/InlineCssLinksIntegrationSpec.js
diff --git a/test/specs/InlineCssSpec.js b/test/specs/InlineCssSpec.js
@@ -2,9 +2,7 @@
 
 var inlineCss = require('../../src/inlineCss'),
     util = require('../../src/util'),
-    testHelper = require('../testHelper'),
-    backgroundValueParser = require('../../src/backgroundValueParser'),
-    ifNotInChromeIt = testHelper.ifNotInChromeIt;
+    backgroundValueParser = require('../../src/backgroundValueParser');
 
 
 describe("Inline CSS content", function () {
@@ -170,24 +168,6 @@ describe("Inline CSS content", function () {
 
             expect(rules[0].cssText).toMatch(/\! ?important/);
         });
-
-        xit("should inline both backgroundImage and background when in the same rule to catch CSSOM.js way of handling the shorthand form", function () {
-            var rules = parseRules('span { background: url("../green.png"); background-image: url("../blue.png"); }');
-
-            joinUrlSpy.and.callFake(function (base, url) {
-                if (url === "../green.png" && base === "below/some.css") {
-                    return "green.png";
-                } else if (url === "../blue.png" && base === "below/some.css") {
-                    return "blue.png";
-                }
-            });
-
-            inlineCss.adjustPathsOfCssResources("below/some.css", rules);
-
-            expect(rules[0].style.getPropertyValue('background')).toEqual('url("green.png")');
-            expect(rules[0].style.getPropertyValue('background-image')).toEqual('url("blue.png")');
-        });
-
     });
 
     describe("loadCSSImportsForRules", function () {
@@ -555,8 +535,7 @@ describe("Inline CSS content", function () {
                 });
             });
 
-            // cssom is much more forgiving that the browsers
-            ifNotInChromeIt("should ignore an invalid value together with a valid url", function (done) {
+            it("should ignore an invalid value together with a valid url", function (done) {
                 var rules = parseRules('span { background-image: "invalid url", url("valid/url.png"); }');
 
                 extractCssUrlSpy.and.callFake(function (value) {
@@ -684,26 +663,6 @@ describe("Inline CSS content", function () {
                 });
             });
 
-            xit("should inline both backgroundImage and background when in the same rule to catch CSSOM.js way of handling the shorthand form", function (done) {
-                var anImage = "anImage.png",
-                    anImagesDataUri = "data:image/png;base64,someDataUri",
-                    anotherImage = "anotherImage.png",
-                    anotherImagesDataUri = "data:image/png;base64,otherDataUri",
-                    rules = parseRules('span { background: url("' + anotherImage + '"); background-image: url("' + anImage + '"); }');
-
-                mockGetDataURIForImageURL(anImage, anImagesDataUri);
-                mockGetDataURIForImageURL(anotherImage, anotherImagesDataUri);
-
-                inlineCss.loadAndInlineCSSResourcesForRules(rules, {}).then(function (result) {
-                    expect(result.hasChanges).toBe(true);
-
-                    expect(rules[0].style.getPropertyValue('background')).toEqual('url("' + anotherImagesDataUri + '")');
-                    expect(rules[0].style.getPropertyValue('background-image')).toEqual('url("' + anImagesDataUri + '")');
-
-                    done();
-                });
-            });
-
             it("should not return an error twice for a missing image", function (done) {
                 var rules = parseRules('span { background: url("someImage.png"); background-image: url("someImage.png"); }');