Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RedbKey for Option<T: RedbKey> #695

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Implement RedbKey for Option<T: RedbKey> #695

merged 3 commits into from
Oct 1, 2023

Conversation

cberner
Copy link
Owner

@cberner cberner commented Sep 30, 2023

Fixes #692

@cberner
Fix as_bytes() for Option<T> when T is fixed width
2a39fe3 
Previously a length 1 buffer would be returned for the None type,
instead of a length 1 + T::fixed_width().
This did not result in data corruption because the buffer these are
copied into was sized as Option<T>::fixed_width(). Still the
implementation was incorrect.
@cberner
Implement RedbKey for Option<T: RedbKey>
13604b5
@cberner
Add assertion to catch misimplemented fixed width types
51af049
@cberner cberner merged commit b87587c into master Oct 1, 2023
@cberner cberner deleted the option_type branch October 1, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RedbKey for Option<RedbKey>
1 participant
@cberner