Revert "Use random port for DevTools tests"

This reverts commit 4630c22.
cazoole · Oct 30, 2018 · 744cdf4 · 744cdf4
1 parent 4630c22
commit 744cdf4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...tests/src/test/java/org/springframework/boot/devtools/tests/DevToolsIntegrationTests.java b/...tests/src/test/java/org/springframework/boot/devtools/tests/DevToolsIntegrationTests.java
@@ -80,9 +80,7 @@ public void launchApplication() throws Exception {
 
 	@After
 	public void stopApplication() throws InterruptedException {
-		if (this.launchedApplication != null) {
-			this.launchedApplication.stop();
-		}
+		this.launchedApplication.stop();
 	}
 
 	@Test

diff --git a/...ests/src/test/java/org/springframework/boot/devtools/tests/RemoteApplicationLauncher.java b/...ests/src/test/java/org/springframework/boot/devtools/tests/RemoteApplicationLauncher.java
@@ -40,12 +40,12 @@ public LaunchedApplication launchApplication(JvmLauncher javaLauncher)
 			throws Exception {
 		LaunchedJvm applicationJvm = javaLauncher.launch("app",
 				createApplicationClassPath(), "com.example.DevToolsTestApplication",
-				"--server.port=0", "--spring.devtools.remote.secret=secret");
-		int port = awaitServerPort(applicationJvm.getStandardOut());
+				"--server.port=12345", "--spring.devtools.remote.secret=secret");
+		awaitServerPort(applicationJvm.getStandardOut());
 		LaunchedJvm remoteSpringApplicationJvm = javaLauncher.launch(
 				"remote-spring-application", createRemoteSpringApplicationClassPath(),
 				RemoteSpringApplication.class.getName(),
-				"--spring.devtools.remote.secret=secret", "http://localhost:" + port);
+				"--spring.devtools.remote.secret=secret", "http://localhost:12345");
 		awaitRemoteSpringApplication(remoteSpringApplicationJvm.getStandardOut());
 		return new LaunchedApplication(new File("target/remote"),
 				applicationJvm.getStandardOut(), applicationJvm.getStandardError(),