Use Cursor.next instead of Cursor.nextObject #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
force-pushed
the
fix/upgrade-mongo
branch
from
69a927a
to
700a5b6
Compare
|
Hmm, is this module still being actively maintained? We just went through the 3.x compatibility process for other things, so this is a little worrisome. |
|
Thanks for the workaround, but my concern was more about long term maintenance of the module etc. In any case I ultimately decided that given the way MongoDB hosting is priced relative to S3 and relatives, I can't really justify keeping files in it due to their size, even if it's one less separate cost and separate service to manage. But maybe that will be worth it to some client at some point... |
|
Hi guys, thanks for contributing to the project, I will review this tomorrow morning, I am jam with bunch of work. |
aslafy-z
force-pushed
the
fix/upgrade-mongo
branch
from
ff76968
to
700a5b6
Compare
|
@cayasso Could you please include this fix in the next release ? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change in mongodb package prevent passing an mongodb instance from version
>=3.0.Cursor.nextObjectis deprecated since2.0and removed from api since3.0Similar: aheckmann/gridfs-stream#125