This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Use Docker's multi-stage builds #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuharuohzeki
force-pushed
the
multistage-again
branch
from
3eb105a
to
57f2346
Compare
tetsuharuohzeki
commented
Jul 8, 2020
| WORKDIR /root/ | ||
| COPY --from=builder /gh-action-detect-unmergeable/ghaction_unmergeable_detection . | ||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
In #90, I forgot this line
|
By https://github.com/cats-oss/github-action-detect-unmergeable/actions, if we do this, the time of docker build will increase some seconds and we can assume that it will be more longer by installing ca-certificates. I hesitate to merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This try again #90