Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen dismissable dialog advertising the new timetable.cssa.club site #388

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

OliverBalfour
Copy link
Contributor

Here's what it looks like when I inject the HTML and CSS I've added into anutimetable.com:

image

I assume inserting the code into both HTML files will do the trick

I've also updated the README to direct people to the new repo

@BishopOfTurkey we're still putting in the finishing touches on timetable.cssa.club so I'd appreciate it if you could review/approve these changes now, but hold off on merging them until Tom Plant and I agree it's ready

@pl4nty
Copy link
Contributor

pl4nty commented Jan 15, 2022

Thanks Oliver, agreed. Do we want migrate some feature requests too? #77, #83, #92/#148, and #103 might be worth reviewing.

@OliverBalfour
Copy link
Contributor Author

OliverBalfour commented Jan 15, 2022

Yeah, after the release we could maybe do:

  • 77: SEO (or at least indexing) seems useful! We can leverage existing anutimetable.com SEO with this fix for now IMO
  • 103: Instead maybe a hide button on events that persists into query string and ICS export, so you can exclude prerecorded lectures from your linked calendar?
  • 83: very low priority but could be useful, would need query string persistence + ICS integration

I'll open tickets in the new repo

Time slot stuff is less important imo because we show the full 24 hours and a scroll bar

@pl4nty
Copy link
Contributor

pl4nty commented Jan 15, 2022

Brilliant, we had pretty much the same ideas lol. Prerecorded is a great point too. Config might not have to persist in the qs (maybe local or session storage instead), just in the ics export, but maybe it's safer to share the same state/API across both.

@BishopOfTurkey
Copy link
Collaborator

looks good

@catmanjan looks like the ol' anutimetable is end of life. Hopefully if you are paying for the domain you could get in contact with the cssa and ask them if they want to take ownership of it at https://cssa.club/discord

@OliverBalfour
Copy link
Contributor Author

@BishopOfTurkey we're ready - could you merge this when you get the chance? Thanks

@BishopOfTurkey BishopOfTurkey merged commit 7ec7b0a into catmanjan:master Jan 16, 2022
@pl4nty pl4nty deleted the cssa-ad branch January 18, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants