Simplified parallel structure #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…qdm_publisher into doc_improvements
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…om/catalystneuro/tqdm_publisher into metadata-visualization-improvement
for more information, see https://pre-commit.ci
|
Looks good, code is much cleaner, just one minor comment about the port stuff |
|
@garrettmflynn Some conflicts for some odd reason |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 50.00% 51.00% +1.00%
==========================================
Files 6 6
Lines 100 100
==========================================
+ Hits 50 51 +1
+ Misses 50 49 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
CodyCBakerPhD
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the parallel demo by removing the extra
threadingto accommodate the Flask and HTTP relay server. Since the Flask server is already an HTTP server, we don't need both of them. We can simply use Flask to relay events, then allow that to block the main thread until complete.This more closely mirrors how we'd handle things on the GUIDE.