-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata visualization improvement #55
Conversation
for more information, see https://pre-commit.ci
…qdm_publisher into doc_improvements
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
OOooo, something else I forgot to requestt - would it be possible to add a 'cancel' button on the frontend instead of having to ctrl+C the server each time? (could be useful in the GUIDE as well to cancel a conversion/inspection/upload operation to the best of our ability |
@garrettmflynn Reminder on conflicts here - let me know when you removed the websocket stuff too and I'll take a look at this |
Good to go! Haven't gotten around to the cancel request yet—but I'll see what I can do. |
Hmm this is somewhat complicated given that HTTP requests are one-off. I've seen a few hacks online that indicate that you can detect if the client aborts the request while it's occuring—but these are not super clean. The only other way to do this would be to maintain global references to the running bars / processes and have a Are these solutions something that you would be interested in? |
There's no way to track the PIDs of the processes and send a |
Using that approach, we could notify the browser of related Would that actually achieve what you want? And I'm assuming you really only care about canceling in the parallel demo? Otherwise, we could probably execute everything in this endpoint as a thread, then use the hacks referenced before to send some kill command to that—which would have references to everything directly and could shut it down that way. |
OK after digging deeper into cancellation, the only/best 'safe' way to do this would be to have it as a specific feature of the iteration process on the backend I have an idea for how to implement this in a follow up so I'll kick the bucket down the chain for now |
for more information, see https://pre-commit.ci
…om/catalystneuro/tqdm_publisher into metadata-visualization-improvement
Done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 50.00% 51.00% +1.00%
==========================================
Files 6 6
Lines 100 100
==========================================
+ Hits 50 51 +1
+ Misses 50 49 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix #54