-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc Improvements I] Add more annotations types and docstrings #52
Conversation
for more information, see https://pre-commit.ci
…qdm_publisher into doc_improvements
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I do seem to have broken the front-end display (backend server appears to be running fine) - perhaps I changed some object name in the messages sent to the client without changing what the client expects? |
for more information, see https://pre-commit.ci
Fixed. There was some use of |
Do we want to continue maintaining the WS version of the parallel progress bars? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 52.17% 50.00% -2.18%
==========================================
Files 6 6
Lines 92 100 +8
==========================================
+ Hits 48 50 +2
- Misses 44 50 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It seems distinct enough from Flask that I'm not against having it - I was planning to add further docs to that in a follow-up though (and there seems to be enough of a platform-specific difference in behavior between the two to be useful to highlight as well) |
Thanks for fixing! Frontend works again now Probably enough changes here to merit review & merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thanks for making these changes!
Also changed the name of the original class from
TQDMPublisher
->TQDMProgressPublisher
to be consistent with the new other subclasses - what do you think?