-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Synchronous Demos #43
Conversation
for more information, see https://pre-commit.ci
In addition to comments in changed lines,
|
Any errors in the terminal? |
The same one on the webpage, 404 Worth noting it sent me to port 1234 not 8000 |
Co-authored-by: Cody Baker <[email protected]>
for more information, see https://pre-commit.ci
…qdm_publisher into simplified-demos
Can you try again now that the server functions are run directly? |
for more information, see https://pre-commit.ci
I'm forcing the client to open at |
It opens now, but progress bar itself gives
Are both demos working on your end? |
Ah got it. Fixed, I'd been passing some variables as positional arguments but didn't realize that the preceding |
for more information, see https://pre-commit.ci
Would it be possible to add some test to the left of the button in the multiple demo page to indicate that the button can be clicked multiple times to spawn multiple bars? |
(Both are working now, thanks) |
…qdm_publisher into simplified-demos
for more information, see https://pre-commit.ci
Co-authored-by: Cody Baker <[email protected]>
* enhance documentation; remove remaining anonymous callables; better variable names * finish docstring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
===========================================
+ Coverage 39.77% 54.54% +14.77%
===========================================
Files 5 4 -1
Lines 88 66 -22
===========================================
+ Hits 35 36 +1
+ Misses 53 30 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR splits the synchronous demos based on my discussion with @CodyCBakerPhD yesterday.
Limiting the first demo to a single progress bar per client limits the complexity substantially.
Will start this in draft mode so we can have a robust back-and-forth about organization and other aspects of this PR before a full review.