Simplify demo structure #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@garrettmflynn Thanks so much, this is indeed much better. Still needs some improvements but this gives me a better base to build upon |
CodyCBakerPhD
added a commit
that referenced
this pull request
Mar 11, 2024
* fixing for M1 Mac * Fix name of file targeted * Simplify demo structure (#39) * Simplify synchronous demo * Update docs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * suggestions for readability * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update descriptions and types * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update _server.py * Fix demo * Document the frontend * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update src/tqdm_publisher/_demo/_client.js * Functional websocket declaration (#42) * Update _server.py * more keyword arguments; break up docstring; remove unused capture * more keyword arguments --------- Co-authored-by: Garrett Michael Flynn <[email protected]> --------- Co-authored-by: CodyCBakerPhD <[email protected]> Co-authored-by: Garrett Michael Flynn <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the main demo by making the following changes:
2. Each button click triggers a new TQDM progress bar
3. Each progress bar is run synchronously, for 100 tasks each with a random time, on a new thread
4. The documentation has been updated to indicate how to replace existing TQDM instances