Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sklearn import style #28

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Sklearn import style #28

merged 8 commits into from
Jan 31, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Grants tighter control over what is exposed as imports from the package

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jan 30, 2024
@@ -14,7 +14,7 @@ authors = [
]
description = "Extends the base tqdm progress bar with a subscribe method that can expose updates to external (potentially non-Python) processes."
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missed this one in #24

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 30, 2024 21:50
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbda0ed) 97.05% compared to head (9df99fb) 97.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   97.05%   97.14%   +0.08%     
==========================================
  Files           3        3              
  Lines          34       35       +1     
==========================================
+ Hits           33       34       +1     
  Misses          1        1              
Flag Coverage Δ
unittests 97.14% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/tqdm_publisher/__init__.py 100.00% <100.00%> (ø)
src/tqdm_publisher/_publisher.py 95.23% <ø> (ø)
src/tqdm_publisher/testing.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@CodyCBakerPhD CodyCBakerPhD merged commit e203a3f into main Jan 31, 2024
13 of 14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the sklearn_import branch January 31, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants