Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI; remove minor comments; also run pre-commit #22

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Mostly testing the CI here

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jan 26, 2024
@CodyCBakerPhD
Copy link
Member Author

@garrettmflynn Just so you're familiar with the CHANGELOG CI notification, it's really just there as a 'reminder' - the CHANGELOG doesn't actually have to be updated on every minor PR, only if there's an important bug fix or new feature

Copy link

codecov bot commented Jan 26, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@CodyCBakerPhD
Copy link
Member Author

Oh no, the codecov bot automatically showed up lol

What are you opinions about it? Are the CI reports for patch/project coverage differences useful?

@CodyCBakerPhD CodyCBakerPhD changed the title Trigger CI; remove minor comments Trigger CI; remove minor comments; also run pre-commit Jan 26, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 26, 2024 18:19
@garrettmflynn
Copy link
Collaborator

I'm not super familiar with referring to Codecov reports. I understand the difference between project and patch reports—though I can't say at present whether the difference is useful for me personally.

What is your experience with this?

@CodyCBakerPhD
Copy link
Member Author

What is your experience with this?

Generally I find it pretty annoying

The one place it's useful is on the projects where coverage % is an actual milestone so you want to be able to deny a PR on the grounds it decreases coverage

I can disable the 2 CI in a follow-up; the actual bot reports summary diffs without it being a visible red X on the actions, which is a nice glance

Copy link
Collaborator

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure. Otherwise this looks great!

@CodyCBakerPhD CodyCBakerPhD merged commit 9d5e5d9 into main Jan 26, 2024
19 of 20 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the trigger_ci branch January 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants