-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger CI; remove minor comments; also run pre-commit #22
Conversation
@garrettmflynn Just so you're familiar with the CHANGELOG CI notification, it's really just there as a 'reminder' - the CHANGELOG doesn't actually have to be updated on every minor PR, only if there's an important bug fix or new feature |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Oh no, the codecov bot automatically showed up lol What are you opinions about it? Are the CI reports for patch/project coverage differences useful? |
for more information, see https://pre-commit.ci
I'm not super familiar with referring to Codecov reports. I understand the difference between project and patch reports—though I can't say at present whether the difference is useful for me personally. What is your experience with this? |
Generally I find it pretty annoying The one place it's useful is on the projects where coverage % is an actual milestone so you want to be able to deny a PR on the grounds it decreases coverage I can disable the 2 CI in a follow-up; the actual bot reports summary diffs without it being a visible red X on the actions, which is a nice glance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sure. Otherwise this looks great!
Mostly testing the CI here