Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools #369

Open
wants to merge 24 commits into
base: base_extractor
Choose a base branch
from
Open

Tools #369

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f983cfd
removed unused toy_example
pauladkisson Sep 30, 2024
3d4b52a
split extraction_tools into various submodules
pauladkisson Sep 30, 2024
17b68c1
updated imports to respect new organization
pauladkisson Sep 30, 2024
5019290
moved write_h5 to hdf5imagingextractor
pauladkisson Sep 30, 2024
bccfce1
removed unused validation fns
pauladkisson Sep 30, 2024
82767ee
updated tools.testing import
pauladkisson Sep 30, 2024
92579c5
added tests for importing
pauladkisson Sep 30, 2024
1b82e97
moved mat read tools to sbximagingextractor where they are used.
pauladkisson Sep 30, 2024
2d4ce2d
added consistency tests for typing
pauladkisson Sep 30, 2024
00a894c
added test for show_video
pauladkisson Sep 30, 2024
746b158
renamed dummy --> mock
pauladkisson Sep 30, 2024
e197a60
added tests for generate_mock_video
pauladkisson Sep 30, 2024
1237fe5
added tests for generate_mock_imaging_extractor
pauladkisson Sep 30, 2024
2084dee
added tests for generate_mock_segmentation_extractor
pauladkisson Sep 30, 2024
c43398b
added tests for generate_mock_segmentation_extractor
pauladkisson Oct 1, 2024
77bce27
removed unnecessary/unused checks
pauladkisson Oct 1, 2024
f8cc434
added assert_segmentation_equal
pauladkisson Oct 1, 2024
d2540fd
added assert_imaging_equal and imaging_equal instead of __eq__
pauladkisson Oct 1, 2024
898bd64
updated tests to use new testing tools
pauladkisson Oct 1, 2024
af443be
added tests for assert tools
pauladkisson Oct 1, 2024
8d0b51e
removed commented section
pauladkisson Oct 1, 2024
e6d2bca
updated pixel_mask_extractor and image_mask_extractor
pauladkisson Oct 4, 2024
5c71966
added tests for segmentation_extractor_functions
pauladkisson Oct 7, 2024
1125ff0
fixed file paths for segmentation_extractor2
pauladkisson Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed commented section
pauladkisson committed Oct 1, 2024
commit 8d0b51e3190b3271f29023b986309f444ff71df8
35 changes: 0 additions & 35 deletions tests/test_minimal/test_tools/test_testing.py
Original file line number Diff line number Diff line change
@@ -231,41 +231,6 @@ def test_generate_mock_segmentation_extractor_seed():
assert not segmentation_equal(segmentation_extractor1, segmentation_extractor3)


# def assert_segmentation_equal(
# segmentation_extractor1: SegmentationExtractor, segmentation_extractor2: SegmentationExtractor
# ):
# """Assert that two segmentation extractors have equal fields.

# Parameters
# ----------
# segmentation_extractor1 : SegmentationExtractor
# First segmentation extractor to compare.
# segmentation_extractor2 : SegmentationExtractor
# Second segmentation extractor to compare.


# Raises
# ------
# AssertionError
# If any of the following attributes or data do not match between the two SegmentationExtractor objects:
# - image_size
# - num_frames
# - sampling_frequency
# - _times
# - roi_ids
# - num_rois
# - accepted_roi_ids
# - rejected_roi_ids
# - roi_locations
# - roi_image_masks
# - roi_pixel_masks
# - roi_response_traces
# - background_ids
# - num_background_components
# - background_image_masks
# - background_response_traces
# - summary_images
# """
def test_assert_segmentation_equal_image_size():
segmentation_extractor1 = generate_mock_segmentation_extractor(num_rows=1)
segmentation_extractor2 = generate_mock_segmentation_extractor(num_rows=1)