Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specific error message for single-frame scanimage data #360

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

pauladkisson
Copy link
Member

Fixes #298

Upon reflection, it seems unnecessary to add a whole new imaging extractor to support an edge case that I doubt will actually surface in real ScanImageTiff datasets (single frame files). If we ever run into an actual use case, I will revisit this issue.

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think is reasonable to leave edge cases not implemented and the message seems like the right instruction to me.

@pauladkisson pauladkisson merged commit 735a866 into main Sep 17, 2024
29 checks passed
@pauladkisson pauladkisson deleted the scanimage branch September 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ScanImageTiffSinglePlaneImagingExtractor cannot read files with only 1 frame each
2 participants