Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for tiff imaging extractor #353

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Related to:
catalystneuro/neuroconv#995

The reason why the file could not be memmap should be propagated. This improves the current error handling and displays a more informative error to the final user.

@h-mayorquin h-mayorquin self-assigned this Aug 13, 2024
@CodyCBakerPhD CodyCBakerPhD removed their request for review August 13, 2024 17:36
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be pointing to the current (rather than legacy) versions of ScanImage ImagingExtractor here.

tests/test_scan_image_tiff.py Outdated Show resolved Hide resolved
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @h-mayorquin!

@pauladkisson pauladkisson merged commit 28b843f into main Aug 13, 2024
29 checks passed
@pauladkisson pauladkisson deleted the improve_error_message branch August 13, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants