Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect import in sima #351

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Protect import in sima #351

merged 6 commits into from
Aug 13, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Delaying imports to intialization time is good for perofrmance reasons.

It would also stop from appearing on my stack when I am looking for any exceptions : P

Could we have this please?

@h-mayorquin h-mayorquin self-assigned this Aug 7, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@h-mayorquin
Copy link
Collaborator Author

This should be ready to go.

Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pauladkisson pauladkisson merged commit da6d791 into main Aug 13, 2024
29 checks passed
@pauladkisson pauladkisson deleted the protect_import_in_sima branch August 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants