Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cron Bug with Assess-file-changes #310

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix Cron Bug with Assess-file-changes #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e24c6d7
exclude assess-file-changes.yml from check
pauladkisson Apr 16, 2024
580f016
Merge branch 'main' into assess_file_changes
pauladkisson Apr 16, 2024
4e69016
updated changelog
pauladkisson Apr 16, 2024
239d2c4
excluding setup.py from changelog check
pauladkisson Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/assess-file-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
echo "CHANGELOG_UPDATED=false" >> $GITHUB_OUTPUT
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
echo $file
if [[ $file == "src/"* || $file == "tests/"* || $file == "requirements-minimal.txt" || $file == "requirements-testing.txt" || $file == "setup.py" || $file == ".github/"* ]]
if [[ $file == "src/"* || $file == "tests/"* || $file == "requirements-minimal.txt" || $file == "requirements-testing.txt" || $file == ".github/"* && $file != ".github/workflows/assess-file-changes.yml" ]]
then
echo "Source changed"
echo "SOURCE_CHANGED=true" >> $GITHUB_OUTPUT
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

* The triggering workflow name for update version was incorrectly set to `auto-publish` (the name of the yaml file). It has been renamed to `Upload Package to PyPI` (the name field of the workflow): [PR #304](https://github.com/catalystneuro/roiextractors/pull/304).

* Fixed bug with automatic changelog test that was causing it to fail for daily tests: [PR #310](https://github.com/catalystneuro/roiextractors/pull/310)

# v0.5.7

### Features
Expand Down
Loading