Update Suite2pSegmentationExtractor to support multi channel and multi plane outputs
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/roiextractors/extractors/suite2p/suite2psegmentationextractor.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
4 tasks
|
@weiglszonja Can you also include some of the fixes/improvements from https://github.com/catalystneuro/roiextractors/pull/227/files while working on this? Such as safe loading (based on file existence) for each of the response series types |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tor' into update_suite2psegmentationextractor
weiglszonja
commented
Oct 5, 2023
src/roiextractors/extractors/suite2p/suite2psegmentationextractor.py
Outdated
Show resolved
Hide resolved
…com/catalystneuro/roiextractors into update_suite2psegmentationextractor
5 tasks
…tor' into update_suite2psegmentationextractor
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 78.96% 79.00% +0.04%
==========================================
Files 39 39
Lines 2985 3029 +44
==========================================
+ Hits 2357 2393 +36
- Misses 628 636 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
weiglszonja
requested review from
alessandratrapani
and removed request for
CodyCBakerPhD
|
@pauladkisson @alessandratrapani Can I get your help reviewing this PR? Thanks in advance |
alessandratrapani
approved these changes
Nov 6, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #234
Also in catalystneuro/pinto-lab-to-nwb#9
The interface PR: catalystneuro/neuroconv#601