Remove spikeextractors dependency

[CodyCBakerPhD]

ROIExtractors does not test or make use of any of the methods inherited from the BaseExtractor imported from the legacy spikeextractors. This removes it from the minimal installation and base ImagingExtractor.

[codecov]

Codecov Report

Merging #196 (00d666d) into master (3f08c50) will decrease coverage by 0.74%.
The diff coverage is 39.39%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   73.25%   72.51%   -0.75%     
==========================================
  Files          33       33              
  Lines        2176     2190      +14     
==========================================
- Hits         1594     1588       -6     
- Misses        582      602      +20     

Flag	Coverage Δ
unittests	72.51% <39.39%> (-0.75%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/roiextractors/example_datasets/toy_example.py	6.94% <0.00%> (-1.39%)	⬇️
src/roiextractors/extraction_tools.py	61.76% <13.63%> (-5.36%)	⬇️
src/roiextractors/imagingextractor.py	81.11% <100.00%> (-0.21%)	⬇️
src/roiextractors/segmentationextractor.py	87.36% <100.00%> (-0.52%)	⬇️

[h-mayorquin]

Looks good to me and a move the right direction.

Are we still using the decorator for video arguments somewhere? The casting code that you added is related to it but I am not sure that decorator is needed anymore.

[CodyCBakerPhD]

Are we still using the decorator for video arguments somewhere? The casting code that you added is related to it but I am not sure that decorator is needed anymore.

No, we got permission a while back to do away with those completely.

But the casting function I had to port over was something inherited from spikeextractors for some extraction tool function, I didn't looks too deep into it but some time we should really review that module and see what we can do away with.