Merge branch 'main' into add_bioformats

catalystneuro · Jun 5, 2024 · 29e3385 · 29e3385
2 parents 45065f8 + 29c3491
commit 29e3385
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/.github/workflows/dailies.yaml b/.github/workflows/dailies.yaml
@@ -8,10 +8,16 @@ on:
 jobs:
     update-testing-data:
         uses: ./.github/workflows/update-testing-data.yml
+        secrets:
+            AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+            AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+            S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
 
     run-tests:
         needs: update-testing-data
         uses: ./.github/workflows/run-tests.yml
+        secrets:
+            CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
     notify:
         runs-on: ubuntu-latest

diff --git a/.github/workflows/deploy_pr_tests.yaml b/.github/workflows/deploy_pr_tests.yaml
@@ -11,10 +11,16 @@ concurrency:
 jobs:
     update-testing-data:
         uses: ./.github/workflows/update-testing-data.yml
+        secrets:
+            AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+            AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+            S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
 
     run-tests:
         needs: update-testing-data
         uses: ./.github/workflows/run-tests.yml
+        secrets:
+            CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
     dev-tests:
         needs: update-testing-data

diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -2,6 +2,9 @@ name: Full Tests
 on:
   workflow_dispatch:
   workflow_call:
+    secrets:
+      CODECOV_TOKEN:
+        required: true
 
 jobs:
   run:

diff --git a/.github/workflows/update-testing-data.yml b/.github/workflows/update-testing-data.yml
@@ -2,6 +2,13 @@ name: update-testing-data
 on:
   workflow_dispatch:
   workflow_call:
+    secrets:
+      AWS_ACCESS_KEY_ID:
+        required: true
+      AWS_SECRET_ACCESS_KEY:
+        required: true
+      S3_GIN_BUCKET:
+        required: true
 
 jobs:
   run:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@
 * Remove unnecessary `scipy` import error handling: [#315](https://github.com/catalystneuro/roiextractors/pull/315)
 * Fixed the typing returned by the `InscopixImagingExtractor.get_dtype` method: [#326](https://github.com/catalystneuro/roiextractors/pull/326)
 * Detect Changelog Updates was moved to its own dedicated workflow to avoid daily testing failures: [#336](https://github.com/catalystneuro/roiextractors/pull/336)
-* Fixed the Update Testing Data Workflow by unpinning the version of awscli: [#339](https://github.com/catalystneuro/roiextractors/pull/339)
+* Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340)
 
 ### Improvements