-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ophys pipeline (Bruker) #4
Conversation
src/pinto_lab_to_nwb/into_the_void/into_the_void_convert_session.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…d_two_photon_pipeline
for more information, see https://pre-commit.ci
Ah good catch! They have to use the same optical channels too, as optical channels can be a list in imaging plane, even if I'm using the same imaging plane name, the segmentation metadata adds the default name of optical channel because that link is not updated yet. |
@CodyCBakerPhD making this back a draft until the optical channel link is updated too, I'll let you know when it's fixed. |
…d_two_photon_pipeline
for more information, see https://pre-commit.ci
@CodyCBakerPhD updated the files, they should also include the fix for catalystneuro/roiextractors#263 |
Those do look better now - I'll go ahead and merge this then and we'll update the pin to ROI extractors after the upstream PR has a test, been merged, and new release cut in a week or so |
IntoTheVoidNWBConverter
: the converter that automatically adjusts the metadata for the imaging and the segmentation interfaces, and conversion options (through the get_conversion_options method)get_default_imaging_to_segmentation_name_mapping
: returns a dictionary that maps each imaging plane name to the segmentation plane name.This is necessary when there are multiple channels or planes in the imaging data and the segmentation data, as the name
provided in the segmentation interface might not be the same as the name provided in the imaging interface.
Single plane, dual channel example
For example if the imaging data has a single plane with two channels, the default
imaging_to_segmentation_plane_map
will be defined as follows:which will output:
where the keys are the imaging plane names and the values are the segmentation plane names.
This way the converter will automatically set the metadata for the segmentation interfaces to use the same naming convention as the imaging interfaces.
The default mapping can be adjusted by the user as follows:
where "Ch2" will use the first channel provided in the segmentation output from Suite2p, and "Ch1" will use the second channel provided in the segmentation output from Suite2p.
Dual plane, single channel example
For example if the imaging data has two planes with a single channel, the default
imaging_to_segmentation_plane_map
will be defined as follows:where the keys are the imaging plane names and the values are the segmentation plane names.
If the default mapping has to be adjusted, the user can provide a custom mapping as follows:
where "Ch2" will use the first channel provided in the segmentation output from Suite2p, and "Ch1" will use the second channel provided in the segmentation output from Suite2p.