-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over DLC conversion utils #946
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sounds great, good for me ofc! Thanks! |
@h-mayorquin The live service failures should have nothing to do with this I'd think (some out of sync release on DANDI side) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, some questions. I will give it another read tomorrow but this seems like a simple copy-paste which should work. We can merge and then slowly improve as we need it.
from platform import python_version | ||
from typing import List, Optional, Union | ||
|
||
import cv2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this import be protected? I was expecting it to throw imports errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as to why it was not throwing error, it's because we don't test global importability of this private submodule and it's not triggered by anything global (the import of this submodule is itself lazy in the interface usage)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of the protection with __all__
on the __init__
files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read much about the reasoning, only that it triggered on all the ones not contained in the __all__
of that file (which is most if not all of them)
src/neuroconv/datainterfaces/behavior/deeplabcut/deeplabcutdatainterface.py
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Cody Baker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LGTM.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
==========================================
- Coverage 90.76% 90.14% -0.63%
==========================================
Files 125 126 +1
Lines 7085 7214 +129
==========================================
+ Hits 6431 6503 +72
- Misses 654 711 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@h-mayorquin and I talked about this, and it's come up before in the past...
The DLC team has historically taken far too long to even respond to issues, let alone push fixes or review PRs on dlc2nwb
So we're just porting over the util functions here so we have full control over making minor bug fixes or improvements like the recent container name exposure (and no doubt others we'll find over time)
cc @vigji I'll absorb your fixes from DeepLabCut/DLC2NWB#23 and for rebase your NeuroConv PR to this one (assuming I can)