Deprecate stream_id keyword from IntanRecordingInterface
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
force-pushed
the
remove_instan_stream
branch
from
cd61486 to
21460a0
Compare
src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py
Outdated
Show resolved
Hide resolved
src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py
Outdated
Show resolved
Hide resolved
|
One final comment then just need CHANGELOG and this is good to go |
h-mayorquin
force-pushed
the
remove_instan_stream
branch
5 times, most recently
from
c0dd25e to
f4bed0c
Compare
add changelog Update src/neuroconv/datainterfaces/ecephys/intan/intandatainterface.py Co-authored-by: Cody Baker <[email protected]>
h-mayorquin
force-pushed
the
remove_instan_stream
branch
from
f4bed0c to
3eb846f
Compare
h-mayorquin
commented
Mar 30, 2024
CodyCBakerPhD
approved these changes
Mar 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 91.23% 91.38% +0.14%
==========================================
Files 121 121
Lines 6309 6300 -9
==========================================
+ Hits 5756 5757 +1
+ Misses 553 543 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #790.